This repository was archived by the owner on Jun 22, 2025. It is now read-only.
Open
Conversation
This was referenced Jul 9, 2020
ee74005 to
13abe09
Compare
Add support for reloading the Bottle server during development. Eel on the JS side will now try to automatically reconnect to the Python/Bottle server when the websocket dies. This allows us to let the Bottle server die and restart to pull in new changes. An explicit port must be set when we want to use the reloading server to make sure that it restarts on the same port, as that is the port that the JS side will be trying to connect to.
13abe09 to
ed9b880
Compare
Collaborator
Author
|
Need to test this on Windows, make sure it works, and investigate the test failure... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for reloading the Bottle server during development. Eel on
the JS side will now try to automatically reconnect to the Python/Bottle
server when the websocket dies. This allows us to let the Bottle server
die and restart to pull in new changes.
An explicit port must be set when we want to use the reloading server to
make sure that it restarts on the same port, as that is the port that
the JS side will be trying to connect to.